Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: get paced train path endpoint #11051

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Mar 6, 2025

fix #11052

Part of https://github.com/osrd-project/osrd-confidential/issues/779

Implement a get paced train path endpoint

@Wadjetz Wadjetz self-assigned this Mar 6, 2025
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Mar 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (007883a) to head (bad1e42).

Files with missing lines Patch % Lines
editoast/src/views/paced_train.rs 90.32% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11051      +/-   ##
==========================================
+ Coverage   80.62%   80.65%   +0.03%     
==========================================
  Files        1101     1101              
  Lines      112366   112406      +40     
  Branches      747      747              
==========================================
+ Hits        90590    90662      +72     
+ Misses      21733    21701      -32     
  Partials       43       43              
Flag Coverage Δ
editoast 72.30% <94.00%> (+0.12%) ⬆️
front 89.92% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wadjetz Wadjetz force-pushed the ebe/editoast/paced-train-get-path branch from 45fbc42 to 081ee26 Compare March 6, 2025 15:26
@Wadjetz Wadjetz force-pushed the ebe/editoast/paced-train-get-path branch 2 times, most recently from 9d0ae7a to 9365463 Compare March 7, 2025 09:00
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Mar 7, 2025
@Wadjetz Wadjetz requested a review from SharglutDev March 7, 2025 09:01
@Wadjetz Wadjetz marked this pull request as ready for review March 7, 2025 09:14
@Wadjetz Wadjetz requested review from a team as code owners March 7, 2025 09:14
@woshilapin woshilapin changed the title editoast: get paced train path endpont editoast: get paced train path endpoint Mar 7, 2025
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem than #10945, can you update the commit's title to replace "endpont" with "endpoint" 🙏

@Wadjetz Wadjetz force-pushed the ebe/editoast/paced-train-get-path branch from 9365463 to bad1e42 Compare March 7, 2025 13:52
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors cases could be tested, otherwise LGTM, thansk!

Comment on lines +256 to +263
let infra = Infra::retrieve_or_fail(conn, infra_id, || PacedTrainError::InfraNotFound {
infra_id,
})
.await?;
let paced_train = PacedTrain::retrieve_or_fail(conn, paced_train_id, || {
PacedTrainError::PacedTrainNotFound { paced_train_id }
})
.await?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get paced train path endpoint
6 participants